Posts

Day.4 I took a long rest and started again: Remove special handling of TypedReference and RuntimeArgumentHandle

This time I targeted at  this one . It seems so easy to me that I don't even think that it is an issue. However, this is actually kind of difficult, since I'm not yet familiar with the background of the project with merely a PR a few days ago. The request is to remove the special handling of TypedReference  and  RuntimeArgumentHandle in here. ```c if (mono_is_corlib_image (image) && ((m_class_get_byval_arg (klass)->type == MONO_TYPE_TYPEDBYREF) || (!strcmp (m_class_get_name_space (klass), "System") && !strcmp (m_class_get_name (klass), "RuntimeArgumentHandle")))) klass->is_byreflike = 1; ``` Though I submitted the PR for the first time without the 2 conditions mentioned removed, they still rejected me with "This whole if-block can be removed". I understood their thoughts partially since we are supposed to check for the "klass" of its class. However, this is done by placing the cheapest test first and then...
Post a Comment
Read more

Day 3. About Kaggle competitions

I took a look at the Kaggle's microcourse so that I may have more option later to participate in the open source development. TL;DR Off day*1.
Post a Comment
Read more

Day 2. Continued.

So the only job left with me is to modify  mono_error_prepare_exception  to convert the  MONO_ERROR_ARGUMENT_OUT_OF_RANGE   into a MonoException. First I'll have to find the location of mono_error_prepare_exception , so I tried the vim search in folder function :vimgrep /mono_error_prepare_exception/ **/*.* Although I originally meant to add more detail here, I'm too lazy for now, I think I'll paste my PR link here instead: https://github.com/mono/mono/pull/14119 I'll see if I can make one more pull request after I finished my Digital Design HW today. UPDATE: While I didn't finish my Digital Design HW due to some weird error, still my PR has been approved by lambdageek. Great thanks to him. I guessed that maybe I can do one more PR tomorrow on  https://github.com/mono/mono/issues/11959 .
Post a Comment
Read more

Day 1. Make dedicated MonoError for `mono_error_set_argument_out_of_range`

So I decided to choose my first possible PR target as Mono project , which I used it once before to develop some Visual Basic.NET project.(failed though) So this is the first issue I encountered: (#8516) Make dedicated MonoError for `mono_error_set_argument_out_of_range` Although didn't know whether this issue is being resolved or not, this is one of the few which seems to be manageable to me, so I tried to look upon it. Still, I tried to implement some function. ```c void mono_error_set_argument_out_of_range (MonoError *error, const char *param_name) { /* ORIGINAL IMPLEMENTATION ERROR_DECL (error_creating_exception); mono_error_set_exception_handle (error, mono_new_exception_argument_out_of_range (name, error_creating_exception)); mono_error_cleanup (error_creating_exception); */ mono_error_set_specific (error, MONO_ERROR_ARGUMENT_OUT_OF_RANGE, "MonoArgumentException:%s", param_name); if (param_name) mono_error_set_first_argument (error...
Post a Comment
Read more

Day 0. Initialization

So I made up my mind to work on a open source project everyday by following the recommendation on this page: (at least 1 PR per day) => This is too difficult for me right now, so I'll aim for 1PR/2 days. https://www.firsttimersonly.com/ Let's get this show on the road.
Post a Comment
Read more