Day.4 I took a long rest and started again: Remove special handling of TypedReference and RuntimeArgumentHandle
This time I targeted at this one.
It seems so easy to me that I don't even think that it is an issue. However, this is actually kind of difficult, since I'm not yet familiar with the background of the project with merely a PR a few days ago.
The request is to remove the special handling of
```c if (mono_is_corlib_image (image) && ((m_class_get_byval_arg (klass)->type == MONO_TYPE_TYPEDBYREF) || (!strcmp (m_class_get_name_space (klass), "System") && !strcmp (m_class_get_name (klass), "RuntimeArgumentHandle")))) klass->is_byreflike = 1; ```
Though I submitted the PR for the first time without the 2 conditions mentioned removed, they still rejected me with "This whole if-block can be removed".
I understood their thoughts partially since we are supposed to check for the "klass" of its class.
However, this is done by placing the cheapest test first and then check for the class name.
Still, I can't understand why the omission of mono_is_corlib_image is feasible.
Maybe I'll have to wait for their response.
It seems so easy to me that I don't even think that it is an issue. However, this is actually kind of difficult, since I'm not yet familiar with the background of the project with merely a PR a few days ago.
The request is to remove the special handling of
TypedReference and RuntimeArgumentHandlein here.```c if (mono_is_corlib_image (image) && ((m_class_get_byval_arg (klass)->type == MONO_TYPE_TYPEDBYREF) || (!strcmp (m_class_get_name_space (klass), "System") && !strcmp (m_class_get_name (klass), "RuntimeArgumentHandle")))) klass->is_byreflike = 1; ```
Though I submitted the PR for the first time without the 2 conditions mentioned removed, they still rejected me with "This whole if-block can be removed".
I understood their thoughts partially since we are supposed to check for the "klass" of its class.
However, this is done by placing the cheapest test first and then check for the class name.
Still, I can't understand why the omission of mono_is_corlib_image is feasible.
Maybe I'll have to wait for their response.
Comments
Post a Comment